2010YOUY01 commented on PR #24785: URL: https://github.com/apache/datafusion/pull/24785#issuecomment-5479679730
@jayzhan211 and @alamb thanks for the review! > The reservation update after early emission is not always a shrink, and its failure is not impossible. > > At `partial_reduce_stream.rs:356`: This makes sense to me, additionally I think the timing for reservation is also not correct -- it tries to clear the reservation while still holding the batch, and about to actually release right after. This might cause other race conditions. The fix is deleting it, this is an extra sanity check. When going to the next `ReadingInput` state, reservation will be updated again, so it shouldn't have correctness issue. Regression test also added. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
