andygrove opened a new pull request, #5594:
URL: https://github.com/apache/datafusion-comet/pull/5594
## Which issue does this PR close?
Closes #5592.
## Rationale for this change
Comet's agent skills live under `.claude/skills/`. Their content is
vendor-neutral Markdown, so
the directory name ties a shared project asset to one LLM vendor for no
reason.
`apache/datafusion` and `apache/datafusion-python` have both already moved
to `.ai/skills/`, with
symlinks covering the vendor-specific discovery paths. This adopts the same
layout, following
`datafusion-python`, which keeps the `.claude/skills` symlink so the skills
stay discoverable
with no contributor setup.
## What changes are included in this PR?
- Move `.claude/skills` to `.ai/skills` (7 `SKILL.md` files, tracked as
renames).
- Add `.claude/skills` -> `../.ai/skills`, and `CLAUDE.md` -> `AGENTS.md`.
- Drop the `CLAUDE.md` entry from `.gitignore`, which would otherwise shadow
the new symlink.
- Document the layout in a new `## Skills` section in `AGENTS.md`, which
previously did not
mention skills at all, and note that the symlinks are compatibility shims
rather than places
to add content.
- Add `.ai/**` to the RAT excludes in `pom.xml`, keeping `.claude/**` for
the symlink.
- Fix three now-stale `CLAUDE.md` references in skill prose. Two in
`wire-datafusion-function`
meant the reader's own agent config rather than a repo file, so they now
say "agent
instructions / project memory"; the one in `suggest-native-expression`
pointed at `CLAUDE.md`
for build commands, which actually live in
`docs/source/contributor-guide/development.md`.
Skill content is otherwise unchanged, and no documentation needed updating
-- the contributor
guide refers to skills by name, never by path.
### Note for contributors
`CLAUDE.md` was in `.gitignore` so contributors could keep a personal
untracked instruction file
at the repo root. Tracking a `CLAUDE.md` symlink means dropping that entry,
so anyone holding a
personal root `CLAUDE.md` will hit a checkout conflict on pull and will need
to move or delete
it. Both sibling repos accepted the same tradeoff.
## How are these changes tested?
No tests -- this is a file move plus build-config changes with no runtime
behavior. Verified
locally:
- `./mvnw -N apache-rat:check` passes. The report shows `AL CLAUDE.md`, i.e.
RAT follows the
symlink to `AGENTS.md` and finds the ASF header.
- Both symlinks are staged with mode `120000` and resolve correctly;
`.claude/skills` lists all
seven skills.
- `npx prettier "**/*.md" --check` flags exactly the same files before and
after this change, so
the move introduces no new formatting diffs.
I was not able to run `dev/release/run-rat.sh` locally because it downloads
the RAT jar from
Maven Central, which is blocked in my environment. That check should be
unaffected: the moved
files are unchanged and all carry ASF headers, and neither the old nor the
new path appears in
`dev/release/rat_exclude_files.txt`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
