DebadityaHait commented on PR #2397:
URL:
https://github.com/apache/datafusion-ballista/pull/2397#issuecomment-5481044055
Thank you for the review and suggestions @andygrove! I've addressed all
feedback in the latest commit:
1. **Direct ToSchema derivation in allista-core**:
- Added optional utoipa feature to allista-core and derived ToSchema
directly on ExecutorSpecification and ExecutorOperatingSystemSpecification
(including all 9 fields).
- Removed the proxy mirror structs in handlers.rs.
- Added property alignment tests comparing utoipa::ToSchema property sets
directly against serde_json serialization output to guard against future schema
drift.
2. **Cached OpenAPI Document**:
- Wrapped the spec assembly in std::sync::LazyLock so GET
/api/openapi.json returns a cached value.
3. **Kubernetes Health Probes (/healthz and /readyz)**:
- Added #[utoipa::path] annotations to healthz and eadyz in pi::health
and included them in the OpenAPI specification under the health tag.
4. **Schema Property Alignment Tests**:
- Enhanced tests in both allista-api-types and allista-scheduler to
verify that generated schema properties match the serialized JSON keys of DTO
and response instances.
5. **Documentation**:
- Added GET /api/openapi.json to the REST endpoints table in
docs/source/user-guide/scheduler.md.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
