andygrove commented on issue #5574: URL: https://github.com/apache/datafusion-comet/issues/5574#issuecomment-5480143249
Opened #5593 with a warning for the `Compatible` + `convert` returns `None` combination. It does not fix anything here — it just makes the affected cases visible so the cleanup in this issue can be scoped from evidence rather than from a static sweep. Two things it already turned up that are worth recording against this issue. The suppression rule has to key off *descendants only*, because `CometCreateArray`, `CometCreateNamedStruct` and `CometArraysZip` tag themselves when a child fails, so a node's own tag says nothing about whose fault the decline was. And with `spark.comet.exec.scalaUDF.codegen.enabled=false`, every serde that reports `Compatible` and then routes to `emitJvmCodegenDispatch` trips the warning — the disabled-config check lives in the dispatcher rather than in `getSupportLevel`, so that whole family is a real instance of this invariant violation. Moving that check up into `CometCodegenDispatch.getSupportLevel` looks like the cheapest slice of this issue to do first. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
