andygrove commented on PR #2390:
URL:
https://github.com/apache/datafusion-ballista/pull/2390#issuecomment-5483696324
Nice catch on the escape hatch, I reproduced the silent pass on the parent
commit and confirmed the check actually fails on drift now.
One small thing in `crate_source_dirs()`. You derive `_ALL_CRATES` from
`FILES` automatically, which is great, but then the required check right under
it hard-codes `required = {"datafusion-proto-common"}` while the comment above
says "at least one crate per FILES entry must be present". Not a bug today
since the `src is None` path catches a missing crate with a good message, but
it is the same shape of hidden hard-code that caused the original problem, so a
third entry in `FILES` would quietly not be covered. Either derive it from
`FILES` or drop the check and let the `src is None` path own it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
