sunchao commented on PR #5539: URL: https://github.com/apache/datafusion-comet/pull/5539#issuecomment-5485678397
Merged, thanks @1fanwang for the contribution and @andygrove @peterxcli for the review! One nit in the above comments > These tests catch the leaks indirectly. `withIsolatedStructAllocator` only isolates the C struct allocations, and the imported vector's buffers come from the global `CometArrowAllocator`. Might worth adding a short code comment to explain `withIsolatedStructAllocator`. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
