sunchao commented on code in PR #5598: URL: https://github.com/apache/datafusion-comet/pull/5598#discussion_r3899207375
########## native/spark-expr/Cargo.toml: ########## @@ -244,6 +244,23 @@ name = "abs" harness = false [[bench]] +name = "isnan" +harness = false + +[[bench]] +name = "rlike" +harness = false + +[[bench]] +name = "create_named_struct" +harness = false + +[[bench]] +name = "get_struct_field" +harness = false + +[[bench]] +name = "from_json" Review Comment: [P1] Separate the `from_json` and `modulo` benchmark entries Could you give `from_json` its own `harness = false` and start a new `[[bench]]` table before `modulo`? Both `name` assignments currently belong to the same table, so Cargo rejects the native workspace manifest before any target can compile. This blocks ordinary native builds as well as these benchmarks. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
