dwsmith1983 commented on PR #5568: URL: https://github.com/apache/datafusion-comet/pull/5568#issuecomment-5488431923
Thanks for running the digest matrix — good to have the spill path independently covered, and glad the win held up end to end. The criterion suite now has a high-partition group (200/2,000/8,000, hash partitioning, no compression) so PR Benchmark Check can actually watch this; on my machine it lands at 2.75/9.44/21.5 ms respectively. The retention and convention comments are addressed inline, and the description is reworded per your squash-merge point. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
