kosiew commented on code in PR #23468:
URL: https://github.com/apache/datafusion/pull/23468#discussion_r3901982282
##########
datafusion/substrait/tests/cases/roundtrip_logical_plan.rs:
##########
@@ -344,10 +344,39 @@ async fn aggregate_multiple_keys() -> Result<()> {
#[tokio::test]
async fn aggregate_grouping_sets() -> Result<()> {
- roundtrip(
- "SELECT a, c, d, avg(b) FROM data GROUP BY GROUPING SETS ((a, c), (a),
(d), ())",
+ let proto = roundtrip_with_ctx(
+ "SELECT a, c, d, avg(b), sum(e) FROM data GROUP BY GROUPING SETS ((a,
c), (a), (d), ())",
Review Comment:
Nice coverage of the serialized mapping here. Could we also assert the
result set for this multi-measure round trip, or compare the batches before and
after the round trip? That would help catch a case where the plan text and
schema look correct, but the measure values are accidentally swapped during
execution.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
