rluvaton commented on issue #24704: URL: https://github.com/apache/datafusion/issues/24704#issuecomment-5491707084
@Rachelint I agree that for optimally we should have 2 implementation one for sorted and one for not. for sorted we really only need 2 functions emit until in progress, and emit all. for unsorted we can still have emit early in case of `skip_partial_aggregation_probe_ratio_threshold` config, but not having first there is ok for me. I think the sorted case can be added regardless (I already asked for it a long time ago) and it can fallback to current impl -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
