parthchandra commented on PR #840: URL: https://github.com/apache/datafusion-comet/pull/840#issuecomment-2296937499
> I'm not sure this is the best approach but it was previously not possible to have a default value of `false` for `spark.comet.exec.OPNAME.enabled` because it would be enabled anyway if all execs were enabled. Would it be better to have have an exclusion list (does not have to be a config, could just be an internal list) which is explicitly checked if EXEC_ALL is enabled? So op is enabled if ( (EXEC_ALL && not in EXEC_ALL_EXCLUSIONS) || op is enabled) ? We can include an op in exclusions if we feel it is not ready and it can be enabled explicitly for development/testing. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
