viirya commented on code in PR #842:
URL: https://github.com/apache/datafusion-comet/pull/842#discussion_r1722068994
##########
spark/src/main/scala/org/apache/comet/CometSparkSessionExtensions.scala:
##########
@@ -226,7 +226,12 @@ class CometSparkSessionExtensions
private def isCometPlan(op: SparkPlan): Boolean =
op.isInstanceOf[CometPlan]
- private def isCometNative(op: SparkPlan): Boolean =
op.isInstanceOf[CometNativeExec]
+ private def isCometNative(op: SparkPlan): Boolean = op match {
+ case _: CometNativeExec => true
+ case AQEShuffleReadExec(q: ShuffleQueryStageExec, _) =>
+ isCometNative(q.plan)
Review Comment:
Hmm, `ShuffleQueryStageExec`'s child must be a `ShuffleExchangeLike` or
`ReusedExchangeExec`. In Comet query, it should be Comet shuffle which is
`CometPlan`.
Did you see there is a `CometNativeExec` under `ShuffleQueryStageExec`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For additional commands, e-mail: github-h...@datafusion.apache.org
