gene-bordegaray commented on code in PR #24670:
URL: https://github.com/apache/datafusion/pull/24670#discussion_r3916480513
##########
datafusion/physical-plan/src/projection.rs:
##########
@@ -1331,12 +1357,20 @@ pub fn update_join_filter(
fn try_collapse_projection_chain(
outer: &ProjectionExec,
) -> Result<Option<Arc<dyn ExecutionPlan>>> {
+ if outer.overrides_metadata()? {
+ return Ok(None);
+ }
Review Comment:
yes I manually confirmed this and this is true. When collapsing we are
reconstructing the combined projection with the outer schema so this guy is
redundant while the inner projection guard isn't.
It was added because I overlook this 😄
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
