pingzh opened a new pull request, #5665: URL: https://github.com/apache/datafusion-comet/pull/5665
## Which issue does this PR close? Closes #5528. ## Rationale for this change Replacing final fields on live Celeborn clients does not guarantee that transport and retry threads observe Comet's ownership hooks. Admission can then be released while payloads remain in flight. Push-state counters alone do not prove that callbacks, retries, and timed-out writes have released those payloads. ## What changes are included in this PR? - Require volatile instance fields for shared transport hook replacements, and reject incompatible clients before native submission or admission registration. - Keep unsupported clients on ordinary Spark/Celeborn shuffle during planning, including collect-limit and top-K. Released Celeborn 0.6.0 and 0.7.0 now take this path even when native shuffle is requested; preserving native support requires a safe completion API. - Add rejection and fallback regressions, model safely published fields in the ownership test doubles, and document the limitation. ## How are these changes tested? - 135 tests passed across `CelebornShufflePartitionPusherSuite`, `CometCelebornShuffleManagerSuite`, and `CometCelebornShufflePlanningSuite` in a root reactor build with Spark 4.1.3 / Scala 2.13.17. Coverage includes retained references on another thread and Spark fallback queries with AQE enabled and disabled. - `CelebornReflectionCompatibilitySuite` passed all 5 tests against each released 0.6.0 and 0.7.0 JAR. These suites were compiled and run separately, including production Java compilation with `--release 11`. - Native build, root Maven packaging for Spark 4.1, Spotless formatting/checks, and `git diff --check` passed. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
