edubraqd commented on PR #24916: URL: https://github.com/apache/datafusion/pull/24916#issuecomment-5533168607
Thanks for the review, both points addressed in the follow-up commit: - The fallback is now limited to `Duration` and `Interval` ORDER BY types (plus those nested in `Dictionary` / `RunEndEncoded`), which compare the same way in the RANGE peer check as in the sort. `Struct` and `Map` keep being rejected at planning time; `window.slt` now has a `Map` case with distinct values and the `Struct` cases as planning errors. - The explanation lives in one place, on the new `supports_free_range_frame` helper next to the fallback. The error in `extract_window_frame_target_type` no longer claims to be offset-specific: it now reads `RANGE window frames are not supported for ORDER BY type ...`. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
