SubhamSinghal opened a new pull request, #24955:
URL: https://github.com/apache/datafusion/pull/24955
## Which issue does this PR close?
- Part of #17427.
## Rationale for this change
## What changes are included in this PR?
- Extended `datafusion/core/benches/pwmj_semi_anti_sql.rs`'s existing
PWMJ-vs-`NestedLoopJoin` sweep with two more cases:
- `Kind::LeftMark`, planned from SQL via an `EXISTS` wrapped in an
always-false disjunction (`x > 100 OR EXISTS (...)`), the one shape that
decorrelates to `LeftMark`. It needs no special handling: like every other case
in this file, the `pwmj_enabled` arm accepts either `PiecewiseMergeJoin` or
`NestedLoopJoinExec`, since the planner itself falls back on a build that
doesn't yet route `LeftMark` to PWMJ.
- A new `bench_pwmj_right_mark_hand_built` benchmark group for
`RightMark`, which has no SQL surface at all (no keyword, no optimizer rule
ever constructs it), so both arms are built directly instead of planned from
SQL text. Since there is no planner to fall back through, it probes
`PiecewiseMergeJoinExec::try_new` up front and skips the whole group with a
printed note instead of panicking, on a build that does not support `RightMark`
yet.
- No production code changes; this is benchmark-only.
## What is the testing strategy for this PR?
This is a benchmark, not a behavior change, so there are no new correctness
tests.
## Are there any user-facing changes?
No. This adds a criterion benchmark only; no production code, public API, or
behavior changes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
