Pranav2612000 commented on issue #24318:
URL: https://github.com/apache/datafusion/issues/24318#issuecomment-5551787561
Hey @2010YOUY01 ! Is this safe to pick up now? I'm looking to start
contributing to datafusion and think this could be a good issue to start with.
Planning to do a change on the lines of
```
if context
.session_config()
.options()
.execution
.enable_migration_aggregate
{
let mode = self.mode;
let input_order_mode = &self.input_order_mode;
let is_true_no_grouping = self.group_by.is_true_no_grouping();
let limit_options =
self.limit_options_supported_by_hash_stream();
match (mode, input_order_mode, is_true_no_grouping,
limit_options) {
(AggregateMode::Partial, InputOrderMode::Linear, false,
true) => {
return
Ok(StreamType::PartialHash(PartialHashAggregateStream::new(
self, context, partition,
)?));
}
/// arms for other stream types
_ => {}
}
}
```
Let me know if this is what you had in mind and I can submit a PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
