andygrove opened a new issue, #5706:
URL: https://github.com/apache/datafusion-comet/issues/5706

   ### Describe the bug
   
   The arrow 59 migration moved `MutableArrayData::extend` to the fallible 
`try_extend`, but `copy_array` turns the error straight back into a panic:
   
   `native/core/src/execution/operators/copy.rs:42` and `:57`
   
   ```rust
   mutable
       .try_extend(0, 0, capacity)
       .expect("extend failed due to offset overflow");
   ```
   
   Both callers are already in `Result` context, so an offset overflow aborts 
the JVM instead of failing the task, which is exactly what arrow deprecated 
`extend` for.
   
   ### Expected behavior
   
   `copy_array` returns `Result<ArrayRef>` and the two call sites propagate, 
turning an offset overflow into a task failure.
   
   ### Additional context
   
   Found while reviewing #5262.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to