andygrove opened a new issue, #5704: URL: https://github.com/apache/datafusion-comet/issues/5704
### Describe the bug The DataFusion 55 branch raises the off-heap size in `CometTPCHQuerySuite` from 2g to 4g: ```scala conf.set(MEMORY_OFFHEAP_SIZE.key, "4g") ``` It is not established whether DataFusion 55 genuinely needs more memory for these queries, or whether this is a consequence of the `peak_mem_used` accounting change in apache/datafusion#22710 that also disabled two `CometAggregateSuite` metric tests. ### Expected behavior If DataFusion 55 really does need more off-heap for TPC-H, that is a user-visible change and belongs in the changelog: anyone who sized their off-heap against TPC-H would be under-provisioned after upgrading. If it is only an accounting artifact, the bump should be reverted along with the metric fix. ### Additional context Found while reviewing #5262. Related to the ignored aggregate metric tests. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
