AshishGhodvinde opened a new pull request, #5721:
URL: https://github.com/apache/datafusion-comet/pull/5721
## Which issue does this PR close?
Closes #5711
## Rationale for this change
`make format` uses Scalafmt, which can wrap long brace-less `if`/`else`
expressions across multiple lines without adding braces. Scalastyle's
`IfBraceChecker` then rejects the formatted code.
Since Scalafmt is the canonical formatter and cannot automatically add
braces, the `IfBraceChecker` rule can conflict with the formatter and leave
code that fails Scalastyle after formatting.
## What changes are included in this PR?
- Disabled `IfBraceChecker` in `dev/scalastyle-config.xml`.
- No Scala source files were changed.
## How are these changes tested?
- Ran Scalastyle directly against the Spark Scala sources:
`mvnw.cmd scalastyle:check -pl spark -Dscalastyle.failOnViolation=true
-Dscalastyle.verbose=true`
- Scalastyle scanned 153 Scala source files and reported no `IfBraceChecker`
violations.
- The check still reports an unrelated existing `Class.forName` violation in
`spark/src/main/scala/org/apache/spark/sql/comet/util/Utils.scala:131`.
- A full `test-compile` could not complete locally because of unrelated
missing generated protobuf/dependency classes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
