kumarUjjawal commented on code in PR #24945:
URL: https://github.com/apache/datafusion/pull/24945#discussion_r3942963979
##########
datafusion/proto-common/src/generated/prost.rs:
##########
@@ -583,6 +583,8 @@ pub struct EmptyMessage {}
pub struct JsonWriterOptions {
#[prost(enumeration = "CompressionTypeVariant", tag = "1")]
pub compression: i32,
+ #[prost(uint32, optional, tag = "2")]
+ pub compression_level: ::core::option::Option<u32>,
Review Comment:
The optional protobuf field preserves binary compatibility, but adding this
public Rust field breaks existing literals such as `JsonWriterOptions {
compression: 0 }`. These now need `compression_level: None` or
`..Default::default()`. Could we correct “There are no breaking API changes” in
the PR description and add a short upgrade note?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
