Xuanwo opened a new pull request, #24964: URL: https://github.com/apache/datafusion/pull/24964
## Which issue does this PR close? - Part of #318. - Umbrella PR: #23738. - Follow-up to #23830. ## Rationale for this change ASOF SQL behavior was split between sqllogictest and Rust integration tests. SQL-level results and plan shapes are easier to review and maintain in SLT, while Rust coverage remains useful for setup that SLT cannot express. GitHub shows the cumulative stack because fork branches cannot be selected as upstream PR bases. The isolated diff is: https://github.com/Xuanwo/datafusion/compare/xuanwo/asof-sql...xuanwo/asof-slt-coverage ## What changes are included in this PR? - Move duplicated coercion, EXPLAIN, USING-output, and validation coverage into `asof_join.slt`. - Add result and plan-shape coverage for right-output filtering, projection pruning, expression operands, empty inputs, duplicate left rows, self joins, and multi-key `USING`. - Keep Rust tests that require multi-partition physical plans, unbounded inputs, cross-batch execution, or direct plan-to-SQL roundtrips. ## Are these changes tested? Yes: - `cargo fmt --all` - `cargo clippy --all-targets --all-features -- -D warnings` - `cargo test -p datafusion-sqllogictest --test sqllogictests --all-features -- asof_join` - `cargo test -p datafusion --test core_integration asof --all-features` - Extended workspace tests from the contributor guide ## Are there any user-facing changes? No. This consolidates and expands coverage for the ASOF SQL contract introduced by #23830. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
