xudong963 commented on code in PR #24957:
URL: https://github.com/apache/datafusion/pull/24957#discussion_r3942861026
##########
datafusion/physical-plan/src/joins/hash_join/exec.rs:
##########
@@ -1193,21 +1221,12 @@ impl HashJoinExec {
let emission_type = if left.boundedness().is_unbounded() {
EmissionType::Final
} else if right.pipeline_behavior() == EmissionType::Incremental {
- match join_type {
- // If we only need to generate matched rows from the probe
side,
- // we can emit rows incrementally.
- JoinType::Inner
- | JoinType::LeftSemi
- | JoinType::RightSemi
- | JoinType::Right
Review Comment:
here says everything not emitting unmatched build rows is emitted
incrementally. LeftSemi emits matched build rows from the final bitmap, not
incrementally.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
