jayzhan211 commented on code in PR #11989:
URL: https://github.com/apache/datafusion/pull/11989#discussion_r1722817604
##########
datafusion/functions/src/core/arrow_cast.rs:
##########
@@ -87,6 +89,10 @@ impl ScalarUDFImpl for ArrowCastFunc {
internal_err!("arrow_cast should return type from exprs")
}
+ fn is_nullable(&self, args: &[Expr], schema: &dyn ExprSchema) -> bool {
+ args.iter().any(|e| e.nullable(schema).ok().unwrap_or(true))
Review Comment:
It seems there are more functions required to customize nullable based on
input's nullability. It indicates we have less non-null test cases. But we can
add them gradually
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
