2010YOUY01 commented on code in PR #24961:
URL: https://github.com/apache/datafusion/pull/24961#discussion_r3944072623
##########
datafusion/physical-plan/src/aggregates/mod.rs:
##########
@@ -1327,35 +1343,27 @@ impl AggregateExec {
matches!(
self.mode,
AggregateMode::Single | AggregateMode::SinglePartitioned
- ) && self.limit_options.is_none()
- && self.input_order_mode == InputOrderMode::Linear
+ ) && self.input_order_mode == InputOrderMode::Linear
Review Comment:
This looks like a possible optimization that was missing from the existing
implementation. Otherwise existing tests will complain (this kind of
optimization usually come with tests asserting plan shape)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
