andygrove opened a new pull request, #5742:
URL: https://github.com/apache/datafusion-comet/pull/5742
## Which issue does this PR close?
<!-- No issue filed; this adds contributor tooling and documentation. -->
Closes #.
## Rationale for this change
Comet has around 170 open pull requests. Almost none of them carried labels,
so
there was no way for a reviewer to filter the backlog down to their area of
expertise: a query like `is:pr is:open label:area:shuffle` returned nothing
useful.
The project already has a documented triage process for issues
(`docs/source/contributor-guide/bug_triage.md`) and a `bug-triage` skill that
automates it. Pull requests had no equivalent.
PR triage differs from issue triage in ways that are easy to get wrong:
- Priority labels are for issues, not PRs.
- The PR title rarely names the subsystem. `perf: reuse zstd compression
contexts across shuffle blocks` never says "shuffle"; the changed files do.
- A `fix:` prefix does not always mean `bug`. A PR adding support for a type
Comet previously fell back on is an enhancement, since nothing was broken.
Capturing these rules means the next triage pass is consistent with this one
rather than re-deriving the conventions from scratch.
## What changes are included in this PR?
- Add `.ai/skills/pr-triage/SKILL.md`. The skill enumerates open PRs, fetches
each PR's changed files to derive its area, applies exactly one type label
(`bug` or `enhancement`) plus the supporting labels (`performance`,
`correctness`, `crash`, `test`, `build`, `documentation`) and the `area:*`
labels, and prints a report. It does not review, comment on, or edit PRs,
and
it asks a human before creating any new area label rather than inventing
one.
- Add a "Pull Request Triage" section to the bug triage guide covering the
three
rules above.
- Bring the area label table in the guide up to date with the labels that
already exist in the repository but were undocumented: `area:Iceberg`,
`area:udf`, `area:memory`, and `area:joins`. Also list the pre-existing
`array expressions`, `map expressions`, `json expressions`, and
`temporal expressions` labels as area indicators.
`area:memory` and `area:joins` were created while triaging the current
backlog:
seven open PRs cover memory pools, reservations, and OOM handling, and three
cover join operators and dynamic filter pushdown, none of which any existing
area described.
## How are these changes tested?
Documentation and agent-skill changes only, with no code paths to test. The
skill was exercised against the live backlog before being written up: all 170
open PRs now carry a type label, and 141 carry at least one area label. The
remainder are plan-rule, AQE, EXPLAIN, and caching changes that the guide
explicitly says should be left without one.
`prettier` passes on both changed files.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
