Jefffrey commented on code in PR #24966:
URL: https://github.com/apache/datafusion/pull/24966#discussion_r3944505031
##########
datafusion/expr/src/udf.rs:
##########
@@ -1040,6 +1018,49 @@ pub trait ScalarUDFImpl: Debug + DynEq + DynHash + Send
+ Sync + Any {
}
}
+/// Default implementation of [`ScalarUDFImpl::coerce_types`].
Review Comment:
i think it would be better to have these as inner functions, see:
- https://github.com/apache/arrow-rs/pull/10893#discussion_r3877296751
benefit is its more clear this is only meant to be used within that
function, and we dont need to bother with this extensive documentation
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
