jackylee-ch opened a new pull request, #24990: URL: https://github.com/apache/datafusion/pull/24990
## Which issue does this PR close? - N/A ## Rationale for this change The `user_doc` blocks for `covar_pop` and `bool_or` are verbatim copies of `covar_samp` and `bool_and`, so the SQL reference documents the wrong function. `covar_pop` is described as sample covariance, and `bool_or` as "true if all non-null input values are true" — the inverse of what it does. Existing tests already show the behaviour differs: `aggregate.slt` gives `covar_samp = 1` vs `covar_pop = 0.666666666667` on the same data, and `bool_and = false` vs `bool_or = true` on the same column. ## What changes are included in this PR? Corrects the description, `syntax_example` and `sql_example` of both, and regenerates `aggregate_functions.md`. ## What is the testing strategy for this PR? Docs only; the behaviour is unchanged and already covered by the `aggregate.slt` cases cited above. ## Are there any user-facing changes? The SQL reference for `covar_pop` and `bool_or` is now correct. No API change. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
