haochunchang commented on issue #11885: URL: https://github.com/apache/datafusion/issues/11885#issuecomment-5559687948
Hi, I am new to datafusion and is trying to get started when come across this good first issue. Following up here - the `Arc<Statistics>` change discussed above is already in place on main (3266eaa), probably in other PRs not mentioned in this issue: - [PartitionedFile.statistics](https://github.com/apache/datafusion/blob/main/datafusion/datasource/src/mod.rs#L149) is `Option<Arc<Statistics>>`, not Statistics. - [FileGroup.statistics](https://github.com/apache/datafusion/blob/main/datafusion/datasource/src/file_groups.rs#L388) is likewise `Option<Arc<Statistics>>`, with [statistics_mut()](https://github.com/apache/datafusion/blob/722cbf2e7ad9a43bc6723f7795fe87e0552eb81f/datafusion/datasource/src/file_groups.rs#L449) using Arc::make_mut for copy-on-write mutation instead of forcing a clone on every write. Given the field is already Arc-wrapped at both the file and group level, and possibly overlap with @2010YOUY01 's ongoing work, I'd propose closing this issue as resolved — happy to be corrected if there's any gap still open. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
