rich7420 opened a new pull request, #5747: URL: https://github.com/apache/datafusion-comet/pull/5747
## Which issue does this PR close? Closes #5706. ## Rationale for this change `copy_array` turns Arrow offset overflow errors into panics even though its callers already return `Result`. Propagate those errors instead. ## What changes are included in this PR? Return `Result<ArrayRef, ArrowError>` from `copy_array`, use `?` for both the array copy and dictionary-value copy, and forward the result directly from the two callers. ## How are these changes tested? Four Rust tests cover array and dictionary-value offset overflow, sliced nullable deep copies, and dictionary copying/unpacking. Overlapping ListView ranges over a NullArray trigger overflow without a large allocation. Restoring the original `expect` calls in a temporary copy makes both overflow tests fail with a panic. [Fork CI](https://github.com/rich7420/datafusion-comet/actions/runs/34042209542) passed: 1,183 Rust tests passed, including all four new tests, with four skipped. The macOS scans job passed on rerun after an HDFS thread-cleanup crash reported in [#4200](https://github.com/apache/datafusion-comet/issues/4200#issuecomment-5560723054). Local crate/test compilation, Clippy, and formatting checks also passed. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
