ryux1 opened a new pull request, #25005: URL: https://github.com/apache/datafusion/pull/25005
## Which issue does this PR close? - Closes #24998. ## Rationale for this change DELETE with LIMIT currently appears to plan successfully, but the table provider receives only the filters and deletes every matching row. Rejecting the unsupported clause prevents a bounded delete from silently becoming an unbounded one and matches the existing UPDATE LIMIT behavior. ## What changes are included in this PR? - reject DELETE LIMIT during SQL planning - remove the unreachable limit construction from delete_to_plan - replace the misleading EXPLAIN snapshots with error regressions, both with and without WHERE ## What is the testing strategy for this PR? - cargo test -p datafusion-sqllogictest --test sqllogictests -- delete - cargo test -p datafusion-sql --lib (88 passed) - cargo clippy -p datafusion-sql --all-targets -- -D warnings - cargo fmt --all -- --check ## Are there any user-facing changes? Yes. DELETE statements containing LIMIT now return a not-implemented planning error instead of accepting the limit and potentially deleting every matching row. There is no public Rust API change. Implementation and validation were completed with AI coding assistance under the account owner’s direction. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
