rich7420 opened a new pull request, #5755: URL: https://github.com/apache/datafusion-comet/pull/5755
## Which issue does this PR close? Part of #5569 (HAVING / ORDER BY SQL coverage). ## Rationale for this change The Spark 4.1.3 patch disables Comet for the entire `having-and-order-by-recursive-type-name-resolution.sql` file, citing #4123. The map-containing grouping-key fallback was fixed by #4157, so restore coverage with Comet enabled. ## What changes are included in this PR? Remove the file-wide `spark.comet.enabled = false` directive and its stale TODO. Regenerate `dev/diffs/4.1.3.diff` from Spark v4.1.3 sources without changing queries or golden results. Regeneration also refreshes the existing pom.xml result hash without changing its patch content. ## How are these changes tested? The regenerated patch applies cleanly to Spark v4.1.3. Comparing the resulting source trees confirms that only the target SQL input changes, and it matches the original Spark file exactly. `git diff --check` passes, and the CI path selector enables Spark 4.1 tests. The Spark 4.1.3 golden file contains 44 query blocks. [Fork CI](https://github.com/rich7420/datafusion-comet/actions/runs/34053390359) passed all seven Spark 4.1 test groups. The logs confirm that both `having-and-order-by-recursive-type-name-resolution.sql` and its `_analyzer_test` variant ran and passed. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
