kosiew commented on code in PR #24813:
URL: https://github.com/apache/datafusion/pull/24813#discussion_r3947578226
##########
datafusion/proto/src/physical_plan/mod.rs:
##########
@@ -374,6 +400,55 @@ mod file_scan_config_serde {
Ok(())
}
+ #[test]
+ fn new_file_scan_config_serde_preserves_explicit_order_flag() ->
Result<()> {
Review Comment:
Optional: could we add protobuf JSON coverage for `preserve_order:
Some(false)` and the legacy case where the field is absent? The `json` feature
supports this representation, and the generated `pbjson` code preserves the
distinction between an explicit `false` and an absent value.
I think this would be useful for protecting the generated JSON/codegen
contract. A test in `datafusion-proto-models` compiled with its `json` feature
would probably be the best place for it, rather than testing the handwritten
serde path here. Not required for this PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
