stantheman0128 commented on PR #1684: URL: https://github.com/apache/datafusion-python/pull/1684#issuecomment-5569409160
Applied to all five: the three plain `flags` lines, the `flags` line on `regexp_replace` that also documents `g`, and `start` on `regexp_count`. Worth flagging, since your reasoning has a consequence I did not expect. `regexp_instr` documents its own parameters the same way I originally did (`flags: Optional regular expression flags...`, `start: Optional position...`), and I copied that wording precisely so the family would read consistently. After this change the four read differently from the fifth, in the opposite direction. I can include `regexp_instr` here so the family lands consistent, or leave it for a separate pass if you would rather keep this PR to the four. Your call. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
