moraistejerina commented on code in PR #25015:
URL: https://github.com/apache/datafusion/pull/25015#discussion_r3950033790
##########
datafusion/substrait/src/logical_plan/consumer/substrait_consumer.rs:
##########
@@ -500,6 +500,16 @@ pub trait SubstraitConsumer: Send + Sync + Sized {
)
}
+ /// Optional Arrow field metadata for a user-defined type, since Arrow has
+ /// no native representation for some UDTs (e.g. JSON maps to plain
+ /// `DataType::Utf8`). `Ok(None)` (the default) attaches nothing.
+ fn consume_user_defined_type_metadata(
+ &self,
+ _user_defined_type: &r#type::UserDefined,
+ ) -> datafusion::common::Result<Option<HashMap<String, String>>> {
+ Ok(None)
Review Comment:
Agreed and implemented
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
