dwsmith1983 opened a new pull request, #5762:
URL: https://github.com/apache/datafusion-comet/pull/5762

   ## Which issue does this PR close?
   
   Closes #5761.
   
   ## Rationale for this change
   
   Pull requests are labeled by hand. Open pull requests mostly carry a type 
label from the title prefix plus one or two `area:*` labels, while most merged 
pull requests carry none, so the labels are not a reliable view of what changed 
where and each one costs a maintainer a click. Issues already get 
`requires-triage` automatically; this does the equivalent for pull requests 
using the scheme maintainers apply manually.
   
   ## What changes are included in this PR?
   
   - `.github/labeler.yml`: path rules for the `area:*` labels (shuffle, scan, 
writer, aggregation, expressions, joins, ffi, memory, udf, Iceberg, ci) and 
`documentation`. `area:ci` and `documentation` apply only when every changed 
file matches, since most pull requests touch a workflow file or a doc in 
passing. The expressions rule excludes the aggregate and UDF paths so those get 
their own label.
   - `.github/workflows/label_prs.yml`: runs `actions/labeler` on 
`pull_request_target` so fork pull requests are labeled too. Nothing from the 
pull request is checked out or executed; the changed file list comes from the 
API. `sync-labels` is off, so labels are only ever added and hand edits stay. A 
second step adds the type label from the conventional commit prefix (`feat`, 
`refactor`, `chore` to `enhancement`; `fix` to `bug`; `perf` to `enhancement` 
and `performance`; `test` to `enhancement` and `test`; `docs` to 
`documentation`; `ci` and `build` to `enhancement` and `build`) on open only, 
and skips dependabot.
   
   The gating labels (`run-spark-*-tests`, `run-iceberg-tests`, `skip-ci`) are 
not in either file, so the workflow cannot apply them. `ci.yml` already ignores 
`labeled` events for anything but those labels, so the added labels produce 
skipped preflight runs and nothing else.
   
   ## How are these changes tested?
   
   The path rules were run against the 40 open pull requests that carry 
`area:*` labels today: 40 label matches, 5 extra labels, 7 missed. The misses 
are judgment calls such as a change confined to the planner being labeled 
`area:expressions`, which the rules cannot see; the extras are a second area on 
a pull request that touches two subsystems. Both YAML files parse, and the 
action's glob semantics (`any-glob-to-any-file`, `all-globs-to-any-file` with 
negations, `any-glob-to-all-files` with a brace glob) were checked against the 
labeler's source. The workflow itself only runs once merged, since it triggers 
on `pull_request_target`.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to