rich7420 commented on code in PR #4901: URL: https://github.com/apache/datafusion-comet/pull/4901#discussion_r3950447564
########## spark/src/main/scala/org/apache/comet/serde/datetime.scala: ########## @@ -950,6 +950,8 @@ object CometMakeYMInterval extends CometCodegenDispatch[MakeYMInterval] object CometMakeDTInterval extends CometCodegenDispatch[MakeDTInterval] +object CometDivideDTInterval extends CometCodegenDispatch[DivideDTInterval] Review Comment: Could you add a before/after benchmark for a projection using this expression? That would show whether avoiding fallback offsets the dispatcher and Arrow conversion costs. Please verify the fallback/dispatch plans and consume the interval result. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
