pepijnve commented on code in PR #25023:
URL: https://github.com/apache/datafusion/pull/25023#discussion_r3950836612
##########
datafusion/common/src/nested_struct.rs:
##########
@@ -1551,6 +1553,46 @@ mod tests {
assert!(result.is_ok());
}
+ #[test]
+ fn test_validate_struct_compatibility_empty_source_and_target() {
Review Comment:
Thanks for catching this. I had fixed the validation, then hit the arrow-rs
error and didn't think of checking the cast implementation itself 🤦♂️
I adjusted the cast implementation and added tests covering the change.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
