xudong963 commented on PR #24809: URL: https://github.com/apache/datafusion/pull/24809#issuecomment-5578557620
Thanks @jayzhan211, addressed in c90e58b and 8098706. A fetched SPM is now replaced in place with a TopK sort over the coalesce, using the merge's original ordering. The helper no longer hands a detached fetch back to the caller. The coalesce also has its own `DistributionContext` to keep the context tree consistent with the plan. Added executable regressions for both `c > 0` and `c = 0`, checking actual results before optimization and after two optimizer passes, plus context integrity. Both fail on the original PR head and pass with the fix, covering fetch placement below the filter and the case where no extra sort is needed. Local validation on 8098706 passes formatting, all-features Clippy, the full lint suite, and extended workspace tests: 10,992 passed, 8 ignored, plus successful SQLLogicTest execution. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
