kosiew commented on code in PR #25012:
URL: https://github.com/apache/datafusion/pull/25012#discussion_r3954433795
##########
datafusion/core/tests/parquet/string_in_list_pruning.rs:
##########
@@ -413,6 +514,118 @@ async fn
check_string_not_in_list_with_truncated_bounds(page_pruning: bool) {
assert_eq!(output.counter("output_rows"), ROWS_PER_UNIT);
}
+#[tokio::test]
+async fn ordered_in_list_parquet_pruning() {
Review Comment:
Could we add one nullable primitive or binary end-to-end case with a NULL
member in the list? The unit tests cover the compact filter-only semantics
well, but I think an integration case would also be useful to exercise the new
Parquet source and full-match path and make sure a compact predicate with NULL
does not accidentally bypass the row filter.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
