buraksenn opened a new pull request, #25058: URL: https://github.com/apache/datafusion/pull/25058
## Which issue does this PR close? - Closes #24623. ## Rationale for this change The CSV sink protobuf hooks accessed state indirectly, allowing new fields to be omitted silently. Auditing the writer options found that compression level, timezone-aware timestamp format, and line terminator were not represented on the wire, so those settings changed after a physical-plan round trip. ## What changes are included in this PR? - Exhaustively destructure `CsvSink`, `CsvSinkExecNode`, and the nested CSV sink/writer option messages. - Add protobuf fields for compression level, timezone-aware timestamp format, and line terminator. - Preserve `None` for optional format strings and reject malformed line terminators. - Regenerate the protobuf models. The protobuf changes are additive and backward compatible. ## What is the testing strategy for this PR? Expanded the CSV sink round-trip test to cover every writer option, optional defaults, and malformed line terminators. Validated with: - `cargo test -p datafusion-proto --test proto_integration roundtrip_csv_sink` - `cargo clippy -p datafusion-datasource-csv -p datafusion-proto-common -p datafusion-proto --all-features --tests -- -D warnings` - `cargo fmt --all --check` ## Are there any user-facing changes? CSV sinks now retain compression level, timezone-aware timestamp formatting, and line terminators across protobuf plan round trips. Invalid wire terminators return an error. The protobuf additions are backward compatible. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
