LucaCappelletti94 commented on code in PR #2482: URL: https://github.com/apache/datafusion-sqlparser-rs/pull/2482#discussion_r3956163558
########## Cargo.lock: ########## @@ -0,0 +1,412 @@ +# This file is automatically @generated by Cargo. +# It is not intended for manual editing. +version = 4 Review Comment: At this time https://github.com/apache/datafusion-sqlparser-rs/blob/main/.tool-versions still specifies Rust `1.75`, and `version = 4` is only supported from `1.78`. I suspect that the current CI misses this because it tests only stable, beta, and nightly, and not specifically `1.75`. I am not sure whether here we would want to either bump `.tool-versions` or downgrade the `version` of the `Cargo.lock`. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
