sunchao commented on code in PR #5766: URL: https://github.com/apache/datafusion-comet/pull/5766#discussion_r3960144902
########## spark/src/test/scala/org/apache/comet/serde/CometLiteralSuite.scala: ########## @@ -0,0 +1,126 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ + +package org.apache.comet.serde + +import scala.util.Try + +import org.apache.arrow.vector.types.TimeUnit +import org.apache.arrow.vector.types.pojo.{ArrowType, Field, FieldType} +import org.apache.spark.sql.CometTestBase +import org.apache.spark.sql.catalyst.util.GenericArrayData +import org.apache.spark.sql.comet.util.Utils +import org.apache.spark.sql.types._ + +import org.apache.comet.CometSparkSessionExtensions.{isSpark40Plus, isSpark41Plus} +import org.apache.comet.serde.literals.CometLiteral +import org.apache.comet.shims.CometTypeShim + +/** + * Pins `CometLiteral.listLiteralElementSupported` against the arms of + * `CometLiteral.makeListLiteral`. The gate exists only to keep an element type the encoder has no + * arm for from reaching it, so a disagreement between the two is not a fallback: the missing arm + * raises a `MatchError` in the middle of planning, which Spark surfaces as `[INTERNAL_ERROR] The + * Spark SQL phase planning failed with an internal error`. + */ +class CometLiteralSuite extends CometTestBase with CometTypeShim { Review Comment: ### Correctness [P2] Register the new literal suite in both build workflows Could you add `org.apache.comet.serde.CometLiteralSuite` to the explicit expression-suite lists in `.github/workflows/pr_build_linux.yml` and `.github/workflows/pr_build_macos.yml`? Neither currently includes it. The repository's `dev/ci/check-suites.py` exits 255 for this omission, which I reproduced at this head. The current [Preflight job](https://github.com/apache/datafusion-comet/actions/runs/34250035832/job/102141816753) fails with the same missing-suite message, so the downstream builds and expression tests are skipped. Registering the suite in both workflows is needed both to unblock CI and to run the new encoder-admission regressions. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
