sam-1112 commented on PR #5215: URL: https://github.com/apache/datafusion-comet/pull/5215#issuecomment-5586677738
Hi @andygrove, just a gentle ping when you get a chance. I’ve added the null-buffer assertion, and the existing dictionary test already covers the `Dictionary(Int32, Utf8View)` path. I think that addresses both points from your latest review. Thanks! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
