alamb commented on issue #24727: URL: https://github.com/apache/datafusion/issues/24727#issuecomment-5591195026
> > Are you suggesting I add it to somewhere else? > > I was actually thinking if it makes sense to have a CI check for any PRs to measure numbers before the merge, and set the binary size metric as the recommendation/requirement. Given that most of PRs are AI generated it might bring some benefit on early capture? WDYT? I think it is a good idea in theory -- however, I worry about the overall amount of additional CI time. For me it takes 15 minutes to build a release build of `datafusion-cli`. one thing we could probably do pretty easily is make a script that measured the size for each merge to main, and then posted a report on the PR after the fact (rather than part of CI) 🤔 I bet that woud take like 10 minutes with an agent (and then a few days to run the actual builds 🤔 ) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
