rich7420 opened a new pull request, #5798: URL: https://github.com/apache/datafusion-comet/pull/5798
## Which issue does this PR close? Part of #5076. ## Rationale for this change The ANSI `get_array_item` and `element_at` SQL fixtures still skip ten error cases for #3375, although the error-message fix has merged. ## What changes are included in this PR? Restore error checks for out-of-bounds indices and `element_at`'s zero index. Add valid boundary queries that check Comet execution and result parity. The literal-array cases use column indices so Spark's `SimplifyExtractValueOps` cannot replace an invalid lookup with NULL when constant folding is disabled. ## How are these changes tested? Both SQL fixtures passed locally on Spark 4.1.3 / JDK 21 after building the native library. This covers the ten restored error cases, valid boundary queries and existing NULL short-circuit tests. [Fork CI](https://github.com/rich7420/datafusion-comet/actions/runs/34313715859) completed with 44 successful checks, including the Linux and macOS expressions jobs. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
