dwsmith1983 commented on PR #5615: URL: https://github.com/apache/datafusion-comet/pull/5615#issuecomment-5602803088
Not intentional, the per-scan memo just never got the same treatment. In 0b2a0b8cf `prepareShared` merges into the memo atomically and returns whichever equal-bytes entry landed first, on both the base-plan and shuffle-scoped paths, and the stale-replacement semantics are unchanged. Two barrier tests mirror the `parseBasePlan` one, four threads on a cold key for 200 trials through `injectPlanData` and `injectPlanDataForShuffle`; before the change 57 and 60 of the 200 trials produced two instances, now none. The description states the guarantee for both memos. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
