adriangb commented on code in PR #24858:
URL: https://github.com/apache/datafusion/pull/24858#discussion_r3969240945
##########
datafusion/functions-aggregate-common/src/aggregate/groups_accumulator.rs:
##########
@@ -576,4 +611,136 @@ mod tests {
assert!(!accumulator.supports_state_preserving());
Ok(())
}
+
+ /// Accumulator whose `size()` is constant, so that the only thing that can
Review Comment:
Agreed, done in 65b3f7e975. The unit tests are gone; the e2e test now has a
shared runner and two cases: 4 MiB retained vs a 1 MiB limit must spill, and
four batches per group under a 2× limit must not spill, which guards against
charging the capacity per batch. Both were checked against main and against a
deliberately per-batch variant.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
