sunchao commented on code in PR #5503:
URL: https://github.com/apache/datafusion-comet/pull/5503#discussion_r3970446244
##########
native/core/src/parquet/parquet_exec.rs:
##########
@@ -217,6 +217,25 @@ pub(crate) fn init_datasource_exec(
Ok(data_source_exec)
}
+// Registration URLs use a reserved suffix to distinguish backend/configuration
+// identities. Encryption must use the physical URI that Spark registered.
Match
+// the complete suffix, from the right, so custom Hadoop schemes are preserved.
+fn physical_object_store_scheme(object_store_url: &ObjectStoreUrl) -> &str {
Review Comment:
I kept these separate because they have different roles: `is_hdfs_scheme`
uses the original URL and configuration to select the Hadoop backend;
`physical_object_store_scheme` removes the internal registration suffix to
recover the scheme encryption expects. The latter handles registration URLs for
both native and Hadoop stores, so it needs to remain independent of backend
selection.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]