viirya commented on code in PR #849:
URL: https://github.com/apache/datafusion-comet/pull/849#discussion_r1723757649
##########
spark/src/main/scala/org/apache/comet/serde/QueryPlanSerde.scala:
##########
@@ -2663,16 +2663,16 @@ object QueryPlanSerde extends Logging with
ShimQueryPlanSerde with CometExprShim
None
}
- case HashAggregateExec(
- _,
- _,
- _,
- groupingExpressions,
- aggregateExpressions,
- aggregateAttributes,
- _,
- resultExpressions,
- child) if isCometOperatorEnabled(op.conf,
CometConf.OPERATOR_AGGREGATE) =>
+ case aggregate: BaseAggregateExec
+ if (aggregate.isInstanceOf[HashAggregateExec] ||
+ aggregate.isInstanceOf[ObjectHashAggregateExec]) &&
Review Comment:
So for `ObjectHashAggregateExec`, the error message will be something like
unsupported aggregate expression?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For additional commands, e-mail: github-h...@datafusion.apache.org
